[MPlayer-cvslog] CVS: main/libmpcodecs ve_lavc.c,1.110,1.111

[Michael Niedermayer]

Hi

On Thursday 24 February 2005 03:53, D Richard Felker III wrote:
> On Thu, Feb 24, 2005 at 03:40:02AM +0100, Richard Felker CVS wrote:
> > CVS change done by Richard Felker CVS
> >
> > Update of /cvsroot/mplayer/main/libmpcodecs
> > In directory mail:/var2/tmp/cvs-serv9723/libmpcodecs
> >
> > Modified Files:
> >  ve_lavc.c
> > Log Message:
> > limiting to positive numbers is nonsense; doesn't match man page either
> >
> > Index: ve_lavc.c
> > ===================================================================
> > RCS file: /cvsroot/mplayer/main/libmpcodecs/ve_lavc.c,v
> > retrieving revision 1.110
> > retrieving revision 1.111
> > diff -u -r1.110 -r1.111
> > --- ve_lavc.c 24 Feb 2005 02:31:41 -0000 1.110
> > +++ ve_lavc.c 24 Feb 2005 02:40:00 -0000 1.111
> > @@ -189,7 +189,7 @@
> >   {"vpass", &lavc_param_vpass, CONF_TYPE_INT, CONF_RANGE, 0, 3, NULL},
> >   {"vrc_strategy", &lavc_param_vrc_strategy, CONF_TYPE_INT, CONF_RANGE,
> > 0, 2, NULL}, {"vb_strategy", &lavc_param_vb_strategy, CONF_TYPE_INT,
> > CONF_RANGE, 0, 10, NULL}, - {"vb_qoffset", &lavc_param_vb_qoffset,
> > CONF_TYPE_FLOAT, CONF_RANGE, 0.0, 31.0, NULL}, + {"vb_qoffset",
> > &lavc_param_vb_qoffset, CONF_TYPE_FLOAT, CONF_RANGE, -31.0, 31.0, NULL},
> > {"vlelim", &lavc_param_luma_elim_threshold, CONF_TYPE_INT, CONF_RANGE,
> > -99, 99, NULL}, {"vcelim", &lavc_param_chroma_elim_threshold,
> > CONF_TYPE_INT, CONF_RANGE, -99, 99, NULL}, {"vpsize",
> > &lavc_param_packet_size, CONF_TYPE_INT, CONF_RANGE, 0, 100000000, NULL},
> > @@ -199,7 +199,7 @@
> >   {"gray", &lavc_param_gray, CONF_TYPE_FLAG, 0, 0, CODEC_FLAG_PART,
> > NULL}, {"mpeg_quant", &lavc_param_mpeg_quant, CONF_TYPE_FLAG, 0, 0, 1,
> > NULL}, {"vi_qfactor", &lavc_param_vi_qfactor, CONF_TYPE_FLOAT,
> > CONF_RANGE, -31.0, 31.0, NULL}, - {"vi_qoffset", &lavc_param_vi_qoffset,
> > CONF_TYPE_FLOAT, CONF_RANGE, 0.0, 31.0, NULL}, + {"vi_qoffset",
> > &lavc_param_vi_qoffset, CONF_TYPE_FLOAT, CONF_RANGE, -31.0, 31.0, NULL},
> > {"vqsquish", &lavc_param_rc_qsquish, CONF_TYPE_FLOAT, CONF_RANGE, 0.0,
> > 99.0, NULL}, {"vqmod_amp", &lavc_param_rc_qmod_amp, CONF_TYPE_FLOAT,
> > CONF_RANGE, 0.0, 99.0, NULL}, {"vqmod_freq", &lavc_param_rc_qmod_freq,
> > CONF_TYPE_INT, 0, 0, 0, NULL},
>
> reversed (quickly) with cvs admin...hope no one minds.
> negative values make sense and should be allowed, but lavc crashes
> with assert(q>0) on them.. :(

feel free to fix, i guess its some missing cliping code, as qp must be >0 and 
with a negative offset it could become negative

[...]
-- 
Michael

"nothing is evil in the beginning. Even Sauron was not so." -- Elrond