[MPlayer-cvslog] CVS: main cfg-mencoder.h,1.89,1.90

[Oded Shimon]

On Tuesday 22 February 2005 23:18, Nico Sabbi wrote:
> Oded Shimon wrote:
> >On Monday 21 February 2005 23:45, Nico Sabbi CVS wrote:
> >>+ {"mpegopts",  mpegopts_conf, CONF_TYPE_SUBCONFIG, 0, 0, 0, NULL},
> >
> >I only JUST noticed, this patch kinda breaks my multiple file patch -
> >-mpegopts should be a CONF_TYPE_GLOBAL option. Same goes for -lavfopts
> >
> >BTW, '-of help' should be updated because of this new mpeg muxer.. it
> > still says '-of mpeg' gives an MPEG-1 stream...
> >
> >- ods15
>
> what does CONF_TYPE_GLOBAL specify? I never used it

I'd say the name is pretty self-exlanitory - it says that this options is not 
per file.

imagine this situation, after multiple file support added:
mencoder a.avi b.avi -of mpeg -mpegopts whatever

if -mpegopts is per-file, it will be loaded only when b.avi is loaded - way 
after the muxer has been initied. There are a lot of options in MEncoder 
which don't have this flag and should, because MEncoder never supported 
multiple files and this wasn't a problem... In my multiple file patch I made 
sure to fix all those, but your -mpegopts is very new. :)

- ods15