[MPlayer-cvslog] CVS: main/libmpdemux demuxer.c, 1.181, 1.182 demux_ogg.c, 1.65, 1.66

[Moritz Bunkus]

Hey,

> -      free(ogg_d);
> -      return 0;
> +      goto err_out;

...

> +err_out:
> +  demux_close_ogg(demuxer);
> +  return 0;

Why not simply replace that free(ogg_d); with demux_close_ogg(demuxer)?
The patch would have been smaller, no need for that ugly goto...

Mosu

-- 
If Darl McBride was in charge, he'd probably make marriage
unconstitutional too, since clearly it de-emphasizes the commercial
nature of normal human interaction, and probably is a major impediment
to the commercial growth of prostitution. - Linus Torvalds

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20050206/2953a0eb/attachment.pgp>