[MPlayer-cvslog] CVS: main/libmpcodecs vf_fspp.c,1.8,1.9

[Rich Felker]

On Sun, Dec 18, 2005 at 10:19:33PM +0100, Michael Niedermayer wrote:
> Hi
> 
> On Sun, Dec 18, 2005 at 05:37:00PM +0100, Jindrich Makovicka wrote:
> > Diego Biurrun wrote:
> > >On Sun, Dec 18, 2005 at 02:35:51PM +0100, Jindrich Makovicka CVS wrote:
> > >
> > >>Modified Files:
> > >>	vf_fspp.c 
> > >>Log Message:
> > >>do not postprocess H264
> > >
> > >
> > >Why?
> > 
> > I thought the fact it turns the H264 filtered output into blurred sh*t 
> > and has to be turned off anyway when playing H264 content is a valid 
> > reason. I can add a "force" flag if you insist.
> 
> no, the only thing needed is to convert the h.264 QP to a h.263 style QP
> IIRC rich had some approximate formula for that, and the h.264 std or the
> lavc source might have one too
> its the same as with mpeg1 vs. mpeg2 QP values ...
> 
> you could certainly argue that h.264 doesnt benefit much from deblocking,
> and that may be true but if the user adds a filter it should be used by
> default

BTW we should recall that the person encoding may have DISABLED loop
filter in h264 because it sucks. Thus postprocessing may be desirable
to some users.

Anyway this change should be reversed.

Yes MPlayer should have a way for users to script which filters get
auto-loaded in which situations, but it does not. Adding nasty hacks
to filters to make them disable themselves under some arbitrary
personal preference situation is not acceptable.

Rich