[MPlayer-cvslog] CVS: main/libvo vo_xv.c,1.168,1.169

[Reimar Döffinger]

Hi,
On Tue, Aug 23, 2005 at 09:37:41PM +0200, Jindrich Makovicka CVS wrote:
> disable DR when rendering OSD elements

I can't see the sense in that change, it more or less breaks -dr but
fixes only a tiny part of the problem.
First of all, it should be enabled again _somewhen_ (if that is at all
possible).
Secondly, you would have to disable direct rendering _before_ drawing
the OSD, since usually the image will have the PRESERVE flag set, so you
are actually not allowed to draw onto it.
Thirdly, this could have been done easier by setting vo_directrendering
to 0 instead of adding another variable.
Also since Alexander is the maintainer of this you shouldn't commit
without asking on the list first!!

Greetings,
Reimar Döffinger