[MPlayer-cvslog] CVS: main/DOCS/tech swscaler_methods.txt, 1.1, 1.2

[Guillaume POIRIER]

Hi,

On 8/23/05, The Wanderer <inverseparadox at comcast.net> wrote:
> Guillaume Poirier CVS wrote:
> 
> > CVS change done by Guillaume Poirier CVS
> >
> > Update of /cvsroot/mplayer/main/DOCS/tech
> > In directory mail:/var2/tmp/cvs-serv12394/DOCS/tech
> >
> > Modified Files:
> >       swscaler_methods.txt
> > Log Message:
> > Typo :)
> 
> But a couple of things still slipped through:

I committed some more right after it.


> >  note: when encoding at a limited amount of bits (not constant quantizer)
> > -than a slightly blured input might look better after decoding than a slightly
> > +then a slightly blured input might look better after decoding than a slightly
> >  sharpend one, especially for lower bitrates
> 
> "blurred", "sharpened"

Should be fixed now.


> Also: I would say either "When encoding" ... "quantizer) a slightly" et
> cetera, or "If you are encoding" ... "quantizer) then a slightly" et
> cetera. I'm not sure which, if either, would be better, but the current
> form doesn't work quite right.

when doing a bitrate-starved encoding ... ?


> I'm not entirely happy with the construction "amount of bits", but I'm
> not sure how to fix it without introducing other problems.

[..]


> (While I'm at this: there is at least one place in that file where there
> is a line which is entirely blank except for roughly a tab-width of
> spaces. I can understand such being useful for cursor-positioning
> convenience in actual source code, but it doesn't seem to serve any
> purpose here, especially since nothing in the file is directly indented;
> would it be acceptable to remove those useless spaces, in the name of
> reducing filesize slightly?)

That's fine with me.


> (And, on loosely the same subject, there are several lines on which
> there are trailing spaces which serve no obvious function; I'd be
> inclined to remove them as well, unless someone objects.)

Same here too: fine with me.

Guillaume

-- 
Live fast, die old, and make very sure everyone knows you were there.
 -- Alan Cox