[MPlayer-cvslog] CVS: main configure, 1.1044, 1.1045 Makefile, 1.329, 1.330

[Rich Felker]

On Mon, Aug 22, 2005 at 10:04:37PM +0200, Jindrich Makovicka wrote:
> Rich Felker wrote:
> > On Mon, Aug 22, 2005 at 07:19:37PM +0200, Jindrich Makovicka wrote:
> > 
> >>Rich Felker wrote:
> >>
> >>>Actually I have no idea what the consequences were since I've never
> >>>used v4l2. However I expect it caused frame skipping or duplication at
> >>>the very least, and possibly broken a/v sync.
> >>
> >>It could cause divide by zero when capturing a source with fps < 1.
> >>Otherwise it would just create a bit longer audio capture buffer, which
> >>doesn't do any harm. But thanks for the fix anyway.
> > 
> > 
> > It's definitely worse than that. The tv demuxer labels the stream as
> > 29 fps, so mencoder will default to 29 fps output. I assume that leads
> > to frame dropping, but I have no idea. Anyway, ANY frame dropping or
> > duplication in interlaced video has disastrous results, so this was a
> > very very bad bug...
> 
> ok. i see, you fixed only the less important part :)

Sorry. I don't have v4l2 so I couldn't test it..

Rich