[MPlayer-cvslog] CVS: main configure, 1.1044, 1.1045 Makefile, 1.329, 1.330

[Torinthiel]

On Sun, Aug 21, 2005 at 10:26:08AM +0200, Michael Niedermayer wrote:
> 
> this is still not good, the commit log should at least contain
> * high level description of what the change does (fixing fps calculation
>   in setup_audio_buffer_sizes()) but actually thats still not good as it
>   says nothing about the conequences of the wrong fps ...
> * low level descrioption / diff summary like (int/int does not produce...)
> * list of bug numbers / mailing list archive links which get fixed
> * possible unwanted sideeffects of the change
> * summary of any test/benchmarks done
> * severity of the bug/change
> * some list of tags from (cosmetic/crash-fix/rounding-fix/security-fix/
>   spelling-fix/indention-fix/untested/new-feature/optimization)

Nice big list. Yes, it would be ideal to have this, but than it's a big
PITA to do it. For example a list of mails forces one to look into the
mail archives to find correct link (I assume most developers use their
own mailboxes, not the HTML archive). Sideeffects - if one knows there
could be any. Rare case unfortunatelly. tests - where it has sense.
Usually it's just 'didn't work before, now works'. Maybe (I don't know
if it's possible with CVS) there could be a form to fill, and then the
mail program could append proper links to each message. But that's just
my 2 cents, feel free to ignore it until I make any change to the code ;)
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3073512
   torinthiel(at)megapolis(dot)pl
   gpg: 0906A2CE fpr: EE3E DFB4 C4D6 E22E 8999  D714 7CEB CDDC 0906 A2CE
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20050821/9c54b857/attachment.pgp>