[MPlayer-cvslog] CVS: main configure, 1.1044, 1.1045 Makefile, 1.329, 1.330

[Michael Niedermayer]

Hi

On Sun, Aug 21, 2005 at 06:25:58AM +0200, Diego Biurrun wrote:
> On Sat, Aug 20, 2005 at 09:30:04PM -0400, Rich Felker wrote:
> > On Sat, Aug 20, 2005 at 06:46:36PM +0200, Diego Biurrun wrote:
> > > 
> > > BTW, can we all try to keep cvs log messages a bit more descriptive?
> > > Things like 10l may be fun and quick to type and the problem may even be
> > > obvious to those in the know, but don't forget that many people are
> > > around to learn and explanations help them.
> > 
> > Are you talking about my v4l2 commit? IMO the error is obvious from
> > the (one-line) patch. Dividing int/int to get a float does not work.
> > Normally I say a lot more than just "10l" (or whatever amount) except
> > when the error is obvious to anyone who knows C, or a typo, or a wrong
> > numbers, etc.
> 
> Let's say that it was inspired by that commit, but I'm talking in
> general, there are many more examples.  Yes, it will be obvious to those
> in the know, but if you look at the output of 'cvs log' then 10l is not
> descriptive unless you see the diff as well, while something like
> "int/int does not produce a float value" is...

this is still not good, the commit log should at least contain
* high level description of what the change does (fixing fps calculation
  in setup_audio_buffer_sizes()) but actually thats still not good as it
  says nothing about the conequences of the wrong fps ...
* low level descrioption / diff summary like (int/int does not produce...)
* list of bug numbers / mailing list archive links which get fixed
* possible unwanted sideeffects of the change
* summary of any test/benchmarks done
* severity of the bug/change
* some list of tags from (cosmetic/crash-fix/rounding-fix/security-fix/
  spelling-fix/indention-fix/untested/new-feature/optimization)
  
[...]

-- 
Michael