[MPlayer-cvslog] CVS: main configure, 1.1044, 1.1045 Makefile, 1.329, 1.330

[Rich Felker]

On Sat, Aug 20, 2005 at 06:46:36PM +0200, Diego Biurrun wrote:
> On Sat, Aug 20, 2005 at 12:06:17PM -0400, Rich Felker wrote:
> > On Sat, Aug 20, 2005 at 10:11:33AM +0200, Diego Biurrun wrote:
> > > On Fri, Aug 19, 2005 at 09:24:33PM +0200, Richard Felker CVS wrote:
> > > > 
> > > > Modified Files:
> > > > 	configure Makefile 
> > > > Log Message:
> > > > remove broken shared libpostproc stuff
> > > 
> > > Can you explain why this is broken and how removing it has helped the
> > > situation?
> > 
> > There is no sense in having static libavcodec but shared libpostproc
> > (which is part of libavcodec since ages ago). If you want to use
> > shared libs, precompile libavcodec and libpostproc from ffmpeg
> > sources, then install them and have mplayer use the external lavc. If
> > you're compiling libavcodec as part of the mplayer source tree, it's
> > always compiled static, and libpostproc should be compiled static too.
> > 
> > As for what's broken, the linker flags for setting soname, etc. don't
> > seem to work on some systems when compiling libpostproc as shared, and
> > produce random nonsensical error messages. Then idiots insist on using
> > --enable-shared-postproc and report bugs about it... So after talking
> > to a couple people on #mplayerdev we quickly concluded that the best
> > thing was to just remove this crap.
> 
> OK, I'm happy with that explanation, thanks.
> 
> BTW, can we all try to keep cvs log messages a bit more descriptive?
> Things like 10l may be fun and quick to type and the problem may even be
> obvious to those in the know, but don't forget that many people are
> around to learn and explanations help them.

Are you talking about my v4l2 commit? IMO the error is obvious from
the (one-line) patch. Dividing int/int to get a float does not work.
Normally I say a lot more than just "10l" (or whatever amount) except
when the error is obvious to anyone who knows C, or a typo, or a wrong
numbers, etc.

Rich