[MPlayer-cvslog] CVS: main/libmpcodecs ve_x264.c,1.33,1.34

[Diego Biurrun]

On Fri, Jul 22, 2005 at 10:26:30AM +0200, Diego Biurrun wrote:
> On Thu, Jul 21, 2005 at 08:54:32PM +0300, Ivan Kalvachev wrote:
> > On 7/21/05, Diego Biurrun <diego at biurrun.de> wrote:
> > > On Tue, Jul 19, 2005 at 07:56:53PM +0200, Ivan Kalvachev CVS wrote:
> > > >
> > > > Modified Files:
> > > >       ve_x264.c
> > > > Log Message:
> > > > add (no)visualize options
> > > >
> > > > --- ve_x264.c 11 Jul 2005 19:02:39 -0000      1.33
> > > > +++ ve_x264.c 19 Jul 2005 17:56:51 -0000      1.34
> > > > @@ -167,6 +168,8 @@
> > > > +    {"visualize", &visualize, CONF_TYPE_FLAG, 0, 0, 1, NULL},
> > > > +    {"novisualize", &visualize, CONF_TYPE_FLAG, 0, 1, 0, NULL},
> > > 
> > > Where's the man page update? ;)
> > 
> > I don't think I should document option that doesn't work.
> > Not yet :)
> > It just hangs for me.
> 
> Why do you commit non-working code in the first place?
> 
> I disagree completely about not committing documentation updates. Please
> always commit the documentation together with the code. Otherwise it
> will get forgotten and the documentation remain incomplete. If the
> feature is alpha or even broken, mark it as such in the documentation,
> but document it anyway.

Ivan, can you document this or revert the patch, please?

Diego