[MPlayer-cvslog] CVS: main configure, 1.980, 1.981 mencoder.c, 1.280, 1.281 Makefile, 1.320, 1.321 cfg-mencoder.h, 1.95, 1.96

[Diego Biurrun]

On Thu, Apr 28, 2005 at 08:21:10AM +0200, Nico Sabbi wrote:
> Diego Biurrun wrote:
> 
> >On Mon, Apr 25, 2005 at 11:33:29PM +0200, Torinthiel wrote:
> >
> >>On Mon, Apr 25, 2005 at 09:08:00AM +0200, Nico Sabbi CVS wrote:
> >>
> >>>@@ -1531,6 +1533,7 @@
> >>>  --disable-internal-faad)	_faad_internal=no	;;
> >>>  --enable-external-faad)	_faad_external=yes	_faad_internal=no ;;
> >>>  --disable-external-faad)	_faad_external=no	;;
> >>>+  --disable-faac)	_faac=no	;;
> >>>
> >>Look around, configure should also accept --enable-faac forcing faac
> >>compilation. No need to mention it in help text though.
> >
> >Looks like you'll have to fix this yourself if Nico won't ...
> 
> sorry, but I forgot about it. If you convince me that it's useful I will 
> patch it,
> but frankly I wonder what's the gain if forcing it breaks compilation

It's a matter of policy and consistency.

Consistency because (almost) all other options in MPlayer's configure
script allow forcing, so --enable-faac should be available as well.

Policy because it has been decided that options in configure should be
forceable.  Yes, compilation can fail, it's for people who know what they
are doing.

Diego