[MPlayer-cvslog] CVS: main/libmpdemux mpeg_hdr.c,1.12,1.13

[Rich Felker]

On Wed, Apr 20, 2005 at 08:19:10PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> On Wednesday, 20 April 2005 at 17:33, Dominik 'Rathann' Mierzejewski wrote:
> > On Wednesday, 20 April 2005 at 17:25, Rich Felker wrote:
> > > On Wed, Apr 20, 2005 at 05:11:43PM +0200, Dominik Mierzejewski CVS wrote:
> > > > CVS change done by Dominik Mierzejewski CVS
> > > > 
> > > > Update of /cvsroot/mplayer/main/libmpdemux
> > > > In directory mail:/var2/tmp/cvs-serv3145
> > > > 
> > > > Modified Files:
> > > > 	mpeg_hdr.c 
> > > > Log Message:
> > > > reversed my previous change and uncommented #include <inttypes.h>
> > > > I'll drink my 10l of cola, but Loren still deserves his share.
> > > 
> > > you'll drink 1000l more for using cvs admin -o so long after the
> > > original bad patch was committed!!!
> > 
> > You could've done it earlier yourself. The issue wasn't clear for
> > a while.
> > 
> > > i reversed this patch and recommitted both correctly.
> > 
> > Thanks.
> 
> No, actually, I take that back. Judging from cvslogs so far, my cvs admin
> -o and new fix _were_ correct. You shouldn't have done anything after my
> 1.13 commit. Removing mpeg_hdr.c and doing cvs update should've cleared
> things up in your local tree. I resent your implication that I had made
> the same mistake twice.

cvs admin -o is STRONGLY DISCOURAGED, unless you use it immediately
after committing a mistake. otherwise everyone who has checked out
your mistake has to delete and re-update the file you reversed, and if
they don't they'll have a corrupt/broken checkout! this is very bad.

rich