[MPlayer-cvslog] CVS: main/libmpdemux mp3_hdr.c,1.8,1.9

[Rich Felker]

On Sun, Apr 17, 2005 at 06:13:45PM +0200, Nico Sabbi wrote:
> Rich Felker wrote:
> 
> >On Sat, Apr 02, 2005 at 12:30:21PM +0200, Nico Sabbi CVS wrote:
> > 
> >
> >>CVS change done by Nico Sabbi CVS
> >>
> >>Update of /cvsroot/mplayer/main/libmpdemux
> >>In directory mail:/var2/tmp/cvs-serv29242
> >>
> >>Modified Files:
> >>	mp3_hdr.c 
> >>Log Message:
> >>added support for mpa layers 1 and 2
> >>   
> >>
> >
> >This patch is broken, or else reveals another bug that was covered up
> >before. I have a 128kbit cbr mp3 file which, when played with this
> >patch, fails to read entirely. A verbose debug run shows mplayer
> >misdetecting its frames as alternating wildly between layers 1 and 3,
> >but mp3_check reports no errors in the file. A short clip is available
> >at:
> >
> >http://brightrain.aerifal.cx/~dalias/mp3_hdr.c-1.9-sux.mp3
> >
> >Rich
> >
> > 
> >
> 
> I can play that sample without problems, with any combination of -ac 
> {mad,mp3,ffmp3}
> and -demuxer {20,35}.
> Yet I saw the alternance of layers 1 and 3; I suspect that 
> decode_mp3_hdr() is being called
> at the wrong place. I'll investigate

Bug found, 1000l to Reimar. :)
It's in 1.29.
Fix will be committed soon.

Rich