[Mplayer-cvslog] CVS: main configure,1.910,1.911
eclipse7 at gmx.net
Mon Sep 20 16:36:01 CEST 2004
Diego Biurrun wrote ( On Mon, Sep 20, 2004 at 08:54:23AM +0200 ):
> Alexander Strasser writes:
> > Tried to correct it (patch attached), the indentation is stupid but I don't
> > want to mix up with cosmetics as this always lead to trouble in the past...
> Please fix the indentation nevertheless, in a second commit should you
> prefer, but you sent a patch without indentation changes for review,
I'll fix the indentation next days.
> > so here is my fix, please look over it. But I think I got it right now.
> I stared long and hard at it and cannot spot any mistakes, commit.
Done, as one can see on this list ;)
> > + if ( ( test `bio2jack-config --version | cut -d '.' -f 2` -ge 3 ) ) >/dev/null 2>&1 ; then
> Nitpickish me would add a space between ">" and "/dev/null" for better
> readability and added consistency.
Forgot your nitpick :(
But I'll add it with my cosmetics patch :)
More information about the MPlayer-cvslog