[Mplayer-cvslog] CVS:

[Felix Buenemann]

On Wednesday 13 October 2004 02:27, D Richard Felker III wrote:
> On Tue, Oct 12, 2004 at 11:58:53AM +0200, Diego Biurrun wrote:
> > D Richard Felker III writes:
> > > On Sun, Oct 10, 2004 at 10:53:55PM +0200, Felix Buenemann wrote:
> > > > On Sunday 10 October 2004 17:44, D Richard Felker III wrote:
> > > > > On Sun, Oct 10, 2004 at 03:27:22AM +0200, Felix Buenemann wrote:
> > > > > > Nevermind, that code uses intel ASM syntax and should be
> > > > > > converted to at&t syntax in order to work. Try the attached
> > > > > > patch, if it works you can commit it (or you prefer if I do?).
> > > > >
> > > > > your attached patch is horribly broken. you need to use gcc inline
> > > > > asm input and output specifiers. MANGLE is not helpful and won't
> > > > > even work except for global variables, and leaving output in eax
> > > > > without saying so won't work either!
> > > >
> > > > Hey, you surely now what you're talking about, so please take my
> > > > patch as a start and fix it the right way. The MANGLE() thing is only
> > > > to fixup symbol naming difference between win (PE?) and elf binaries
> > > > and is usually needed on variables directly refered from inline asm.
> > >
> > > right, but using symbol names only works anyway if you're accessing
> > > global variables, which is pointless here. the inline asm really needs
> > > to be fixed properly to work at all. i know the proper fix because i
> > > did it back in the day before diego and others decided to commit
> > > upstream changes to mplayer cvs that conflicted with my local changes.
> > > but it's ok. i can probably remerge them or just rewrite..
> >
> > Please do, we can then try to get them included upstream.
>
> we can try...the upstream is all windows-centric though, that's why it
> include m$-style asm.
We'll that fixed.h looks skary like a mixup of asm code gathered together by 
google searches =)

> rich

-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________