[Mplayer-cvslog] CVS: main/libmpcodecs vd_xvid4.c,1.2,1.3

[Arpi]

Hi,

> Reimar Döffinger wrote:
> 
> >  
> > Not-so hypothetical case: you have a file that doesn't work but you 
> > know it worked somewhen. So you go through the revision to find the 
> > patch that broke it.
> > Now try to guess how hard it is to find the thing that caused it to 
> > break when the patch consists of hundreds of changed lines but most of 
> > them are only cosmetics. You would have to check each of those whether 
> > they changed something or not.
> 
> 
> Cosmetic only patches are easy to verify:
>     cmp old.o new.o ;

not, if the code is full of either configure-dependent or
arch-dependent #ifdefs. you wont get the whole code
compiled in the .o file...

also, gcc maybe does different optimizations depending
on indentation :)

> Some code  in  mplayer is really unreadable;
> if you cant read the code you can't find the
> bugs or improve ....

if you can find and fix bugs, then you can read any code.
if you cant read any code, then you're a beginner programmer,
not a coder/hacker.
anyway if you need different indent to be able to fix bugs,
feel free to run 'indent' on it, then read it, but fix the
bug in the original file...


A'rpi / MPlayer, Astral & ESP-team

--
MPlayer's new image: happiness & peace & cosmetics & vmiklos