[Mplayer-cvslog] CVS: main/libfaad2 mdct_tab.h, NONE, 1.1 neaacdec.h, NONE, 1.1 ps_dec.c, NONE, 1.1 ps_dec.h, NONE, 1.1 ps_syntax.c, NONE, 1.1 ps_tables.h, NONE, 1.1 Makefile, 1.4, 1.5 README, 1.2, 1.3 cfft.c, 1.4, 1.5 common.c, 1.4, 1.5 common.h, 1.

[Diego Biurrun]

D Richard Felker III writes:
> 
> we discussed it on irc and i apologized. actually the code _is_ broken
> like i claimed, but the insane slowness isn't visible unless you add
> -DFIXED_POINT (well actually it's always insanely slow without that,
> so the difference between versions is only visible with
> -DFIXED_POINT). to be fair, diego _had_ extensively tested the version
> he committed with normal settings, he just didn't realize it could be
> non-slow if you define FIXED_POINT... :)

I'll add a commented out alternative CFLAGS line to libfaad2/Makefile
to make this a bit more discoverable along with a comment that
explains what it does.

Is there a way to tell from MPlayer's output whether a file is SBR or
not?

Here is mplayer -v output from an SBR file:

==========================================================================
Opening audio decoder: [faad] AAC (MPEG2/4 Advanced Audio Coding)
dec_audio: Allocating 4608 bytes for input buffer.
dec_audio: Allocating 49152 + 65536 = 114688 bytes for output buffer.
FAAD: Decoder init done (0Bytes)!
FAAD: Negotiated samplerate: 22050Hz  channels: 6
FAAD: compressed input bitrate missing, assuming 128kbit/s!
AUDIO: 22050 Hz, 6 ch, 16 bit (0x10), ratio: 16000->264600 (128.0 kbit)
Selected audio codec: [faad] afm:faad (FAAD AAC (MPEG2/MPEG4 Audio) decoder)
==========================================================================

Here is mplayer -v output from a non-SBR file:

==========================================================================
Opening audio decoder: [faad] AAC (MPEG2/4 Advanced Audio Coding)
dec_audio: Allocating 4608 bytes for input buffer.
dec_audio: Allocating 49152 + 65536 = 114688 bytes for output buffer.
FAAD: Decoder init done (0Bytes)!
FAAD: Negotiated samplerate: 32000Hz  channels: 2
FAAD: got 112kbit/s bitrate from MP4 header!
AUDIO: 32000 Hz, 2 ch, 16 bit (0x10), ratio: 14000->128000 (112.0 kbit)
Selected audio codec: [faad] afm:faad (FAAD AAC (MPEG2/MPEG4 Audio) decoder)
==========================================================================

Pretty hard to tell the difference..

Any volunteers to add some output to ad_faad.c?

Diego