[Mplayer-cvslog] CVS: main/libmpcodecs vd_xvid4.c,1.2,1.3
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Oct 2 11:27:43 CEST 2004
Hi,
>>Renames xvid_ini to xvid_gbl_init and dec_p to xvid_dec_create
>>That'll make the move to 1.1.x front-end smoother.
>
> WHAT THE HELL ARE YOU TALKING ABOUT????!!!
>
> THIS COMMIT IS PURE COSMETIC, I DON"T SEE ANY FUNCTIONAL CHANGE.
> IT IS NOT POSSIBLE TO IMPROVE ANYTHING!!!
>
> Revert immediately
In his defense: he asked about that several times and got no reply
except from me that I personally don't like it.
As I understood it he didn't want to modify the other patch too much as
he doesn't understand it too well. And committing a patch that contains
both cosmetics and code changes is even more unacceptable.
So tell him how to do it and I have the impression he will do it. I'm
currently too confused by all these discussions that I can't give clear
advice...
Greetings,
Reimar Döffinger
More information about the MPlayer-cvslog
mailing list