[MPlayer-cvslog] CVS: main/libmpcodecs vd_libmpeg2.c,1.37,1.38

[Jindrich Makovicka]

D Richard Felker III wrote:
>> mpi= mpcodecs_get_image(sh,type, flags,
>>                        (width+align)&(~align), (height+align)&(~align));
>>
> 
> hmm, looks like something is just broken and mixing up w/h versus
> width/height versus stride...

this has nothing to do with stride. when you pass such pre-aligned 
arguments to get_image, mpi->w and mpi->h are obviously bogus because 
they are set to the enlarged values, not the real image size. so playing 
any mpeg4 file with dimensions not divisible by 16 with -noslices or 
with postprocessing will crash in the VO. as Reimar suggested, you can 
adjust mpi->w and mpi->h to the correct image size (width x height in 
the vd_ffmpeg case) after the get_image call, but this is a nasty hack. 
what needs to fix is get_image itself. another way is to adjust all VOs 
to check if they don't receive mpi with larger image size than expected, 
but this is another hackish approach, which merely compensates the 
consequence of this bug.

Regards,
-- 
Jindrich Makovicka