[MPlayer-cvslog] CVS: main mplayer.c,1.809,1.810

[Felix Buenemann]

On Monday 15 November 2004 19:24, D Richard Felker III wrote:
> On Mon, Nov 15, 2004 at 05:49:42PM +0100, Reimar D?nger wrote:
> > Hi,
> >
> > > > CVS change done by Reimar Döffinger CVS
> > > >
> > > > Update of /cvsroot/mplayer/main
> > > > In directory mail:/var2/tmp/cvs-serv19664
> > > >
> > > > Modified Files:
> > > >  mplayer.c
> > > > Log Message:
> > > > fix scrolling status line in windows
> > > >
> > > >
> > > > Index: mplayer.c
> > > > ===================================================================
> > > > RCS file: /cvsroot/mplayer/main/mplayer.c,v
> > > > retrieving revision 1.809
> > > > retrieving revision 1.810
> > > > diff -u -r1.809 -r1.810
> > > > --- mplayer.c 9 Nov 2004 20:09:26 -0000 1.809
> > > > +++ mplayer.c 13 Nov 2004 16:10:32 -0000 1.810
> > > > @@ -820,6 +820,11 @@
> > > >      width = screen_width;
> > > >    else
> > > >    width = 80;
> > > > +#ifdef WIN32
> > > > +  // windows command line is broken (MinGW's rxvt works though, but
> > > > we +  // should not depend on that).
> > > > +  width--;
> > > > +#endif
> > >
> > > imo we should always do this. there are many terminals that will
> > > scroll if you write to the last position.
> >
> > I thought about this. But I don't know exactly how many "many" is and I
> > am quite reluctant to workaround IMHO broken terminals to the
> > disadvantage of non-broken ones :-(.
> > So I won't make that change at the moment but I won't complain if you do
> > it...
>
> it's not "broken". there's a flag in termcap/info that tells whether
> it has this behavior or not. either is perfectly valid.
And who will miss one fucking char anyways?

> rich

-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________