[Mplayer-cvslog] CVS: main cfg-mplayer.h,1.214,1.215

[Diego Biurrun]

Sascha Sommer writes:
 > >  > +#ifdef HAVE_DIRECTX
 > >  > +    {"adapter", &adapter_num, CONF_TYPE_INT, CONF_RANGE, 0, 5, NULL},
 > >  > +    {"refreshrate",&refresh_rate,CONF_TYPE_INT,CONF_RANGE, 0,100,
 > NULL},
 > >  > +#endif
 > >
 > > This is bad syntax IMNSHO.  VO specific stuff should not be
 > > implemented as a global option, but as a suboption of the vo driver.
 > > This is current MPlayer policy AFAICT.
 > 
 > Hm, I agree. When I had a first look at the patch I wanted to move
 > these options to videoout because I think they might be usefull for
 > other vos, too. Unfortunatelly I forgot about this when I changed
 > the window handling mess. If noone is agains I will prefix the
 > options with vo_ and move them to video_out.c

OK, if they can be used by other vo drivers then it's OK to implement
them as global options.

 > >   mplayer -vo directx:1:75 movie.nut
 > >
 > > would be so much better than
 > >
 > >   mplayer -vo directx -adapter 1 -refreshrate 75 movie.mkv
 > >
 > 
 > Yes, nut files are of course better than mkv ;)

;)  I was really curious if you (somebody) would notice...

Diego