[Mplayer-cvslog] CVS: main/DOCS/tech patches.txt,1.18,1.19
Diego Biurrun CVS
syncmail at mplayerhq.hu
Sun Jun 27 14:38:41 CEST 2004
CVS change done by Diego Biurrun CVS
Update of /cvsroot/mplayer/main/DOCS/tech
In directory mail:/var2/tmp/cvs-serv13805
Modified Files:
patches.txt
Log Message:
Explain that commenting string operations is important.
patch by Alexander Strasser <eclipse7 at gmx.net>
Index: patches.txt
===================================================================
RCS file: /cvsroot/mplayer/main/DOCS/tech/patches.txt,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- patches.txt 17 Jun 2004 08:43:18 -0000 1.18
+++ patches.txt 27 Jun 2004 12:38:38 -0000 1.19
@@ -31,7 +31,10 @@
any remaining cosmetics!
5. Comment parts that really need it (tricky side-effects etc).
- Commenting trivial code not required. Comments must be English!
+ Always document string operations! Comment on what you are doing
+ and why it is safe. This makes it easy to review and change your
+ code if needed. Commenting trivial code not required.
+ Comments must be English!
6. If you implement new features, add or change command line switches or
modify the behavior of existing features, please do not forget to also
More information about the MPlayer-cvslog
mailing list