[Mplayer-cvslog] CVS: main/DOCS/tech patches.txt,1.21,1.22

Diego Biurrun CVS syncmail at mplayerhq.hu
Tue Jul 27 01:48:32 CEST 2004


CVS change done by Diego Biurrun CVS

Update of /cvsroot/mplayer/main/DOCS/tech
In directory mail:/var2/tmp/cvs-serv3178/DOCS/tech

Modified Files:
	patches.txt 
Log Message:
Wording/spelling suggestions by the Wanderer, merged sections about when to
send separate patches.


Index: patches.txt
===================================================================
RCS file: /cvsroot/mplayer/main/DOCS/tech/patches.txt,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- patches.txt	26 Jul 2004 00:52:56 -0000	1.21
+++ patches.txt	26 Jul 2004 23:48:30 -0000	1.22
@@ -26,7 +26,7 @@
     something, even if it extends other features!
 
  4. Read your patch. We'll *refuse* it if it changes indentation of the
-    code or if it does tab/space conversion or other cosmetical changes!
+    code or if it does tab/space conversion or other cosmetic changes!
 
     NOTE: If you already wrote some code and did cosmetic changes, you can
     use 'diff -uwbBE' to help you remove them. Don't forget to check the
@@ -46,7 +46,8 @@
     speak several languages you are of course welcome to update some of the
     translations as well.
 
- 7. If your patch is very big, try splitting it into several self-contained
+ 7. If you make independent changes, try to send them as separate patches.
+    If your patch is very big, try splitting it into several self-contained
     pieces. Each part can then be reviewed and committed separately.
 
  8. Send your patch to the mplayer-dev-eng mailing list as a base64-encoded
@@ -67,26 +68,24 @@
     but unset the "Mail delivery" option so that you can post without getting
     any mails.
     Try to avoid uploading the patch to a web or FTP site, send it directly
-    to the mailing list. The less steps it takes us to get at the patch the
+    to the mailing list. The fewer steps it takes us to get at the patch the
     higher the likelihood for it to get reviewed and applied. If your patch
     is so big you cannot send it by mail, try splitting it into pieces.
 
  9. Give us a few days to react. We try to review patches as fast as possible,
-    but unfortunately we are constantly overloaded with work, be it MPlayer
+    but unfortunately we are constantly overloaded with work, be it MPlayer-
     related or from our day to day lives. If your patch seems to be ignored,
     please resend it and mention that you got ignored. We are interested in
     your work and will eventually either accept it or reject it with an
     explanation of what we disliked about your patch.
 
-10. Do not immediately ask for CVS write access. If you contributed one or
+10. Do not immediately ask for CVS write access. If you have contributed one or
     more nice, acceptable patches and they need maintaining or you want to
     be an MPlayer developer, you'll get CVS write access.
 
-11. For consistency reasons all option names must use '-' instead of '_'.
+11. For consistency reasons, all option names must use '-' instead of '_'.
 
-12. If you made a nontrivial contribution and wish to be mentioned in the
+12. If you make a nontrivial contribution and wish to be mentioned in the
     AUTHORS file, include that in your patch.
 
-13. If you made independent changes, try to send them as separate patches.
-
 Thank you!




More information about the MPlayer-cvslog mailing list