[Mplayer-cvslog] CVS: main/libao2 ao_alsa.c,1.3,1.4

[Zsolt Barat]

Reimar Döffinger wrote:

>
>> -    if (str_status != "running")
>> +    if (snd_pcm_status_get_state(status) == SND_PCM_STATE_RUNNING)
>
>
> are you sure you don't want to use my strcmp variant? Maybe the state 
> could change in between those two calls to snd_pcm_status_get_state.
> Ok, probably only a theoretical problem...
> But it still should be != not ==, shouldn't it?

yes 100l to me, it should be !=, but putting the status in a char is 
nonsens and to take the status at this time is quite right.

greetings

zsolt
 

> Greetings,
> Reimar Döffinger
>
> _______________________________________________
> Mplayer-cvslog mailing list
> Mplayer-cvslog at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-cvslog
>