[MPlayer-cvslog] CVS: main/libvo vo_directx.c,1.42,1.43

[Felix Buenemann]

On Tuesday 21 December 2004 23:04, D Richard Felker III wrote:
> On Tue, Dec 21, 2004 at 09:32:29PM +0100, Joey Parrish CVS wrote:
> > CVS change done by Joey Parrish CVS
> >
> > Update of /cvsroot/mplayer/main/libvo
> > In directory mail:/var2/tmp/cvs-serv25575/libvo
> >
> > Modified Files:
> >  vo_directx.c
> > Log Message:
> > automatic monitoraspect calculation for vo_directx.
> >
> >
> > Index: vo_directx.c
> > ===================================================================
> > RCS file: /cvsroot/mplayer/main/libvo/vo_directx.c,v
> > retrieving revision 1.42
> > retrieving revision 1.43
> > diff -u -r1.42 -r1.43
> > --- vo_directx.c 21 Dec 2004 20:31:39 -0000 1.42
> > +++ vo_directx.c 21 Dec 2004 20:32:26 -0000 1.43
> > @@ -80,6 +80,7 @@
> >  extern int vo_rootwin;
> >  extern int vidmode;
> >  extern int vo_colorkey;
> > +extern float monitor_aspect;
> >
> > 
> > /************************************************************************
> >***** * DirectDraw GUIDs.
> > @@ -1196,6 +1197,7 @@
> >      RECT rd;
> >      vo_screenwidth = monitor_rect.right - monitor_rect.left;
> >      vo_screenheight = monitor_rect.bottom - monitor_rect.top;
> > +    monitor_aspect = (float)vo_screenwidth / (float)vo_screenheight;
>
> THIS IS BLATENTLY WRONG!!! REVERSE!!!
>
> Aspect is PHYSICAL size, not size in pixels!!!!!
> i.e. 1280x1024 is not 4:3 pixels but is 4:3 monitor_aspect!!!
Agree, I was going to say the same. There is virtually no way to detect 
monitor aspect (it is the aspect of the visible area of you display device).

> Rich


-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________