[Mplayer-cvslog] CVS: main mencoder.c, 1.251, 1.252 mp_msg.h, 1.29, 1.30 mplayer.c, 1.774, 1.775

[Attila Kinali]

On Tue, Aug 24, 2004 at 05:23:20PM -0400, The Wanderer wrote:
 
> Actually, it occurs to me to wonder: since the second argument to
> mencoder_exit is a string to be printed, why does this print a message
> itself and then make a call to mencoder_exit with a null string? It
> would seem to make more sense to just pass the desired string to
> mencoder_exit directly.
 
Ack, just wondered myself.
IMHO if we exit and print a message, it should be given to exit_player
resp mencoder_exit (why the heck are they named with different logic?)
but IMHO we need an additional argument to pass the MSGL, currently
it just outputs a MSGL_INFO which may not be printed in all cases.

BTW: can someone explain/document how mp_msg works ? especialy
the selection on what should be printed. It seems a little bit
obfuscated to me.


			Attila Kinali