[Mplayer-cvslog] CVS: main/libvo x11_common.c,1.176,1.177

[Jindrich Makovicka]

Jindrich Makovicka wrote:
> Ivan Kalvachev wrote:
> 
>> I'm not X expert, but this commit looks fishy to me.
>> Are you sure that you haven't broke the xinerama support.
>>
>> It is very easy to break many WM by making fox for only one. Have you
>> tested with more WM that fvwm?
> 
> 
> It works at least with Metacity. I am not 100% sure about xinerama.
> 
>> Please, We have an very active X code maintainer, consult with him
>> before making commit.
>> Especially in so sensible code as X fullscreen one.
>>
>> More...
>> about libmpeg2 update that you have commited some time ago. Are you aware
>> that it cannod decode B-frames atm, givin alful image of mplayer atm.
>> If you don't fix it in few hours, the whole code will be reverted.
> 
> 
> Yes, I am aware of it, but feel free to revert it, I still cannot find 
> the bug.

It seems to have trouble with two consecutive B-frames. Because the 
newer libmpeg2 returns the decoder states in differerent order, the 
image buffer is clobbered before the previous frame gets displayed. I 
will try to make some workaround, so please don't revert yet (say, till 
tomorrow).

-- 
Jindrich Makovicka