[Mplayer-cvslog] CVS: main/libvo x11_common.c,1.176,1.177

[Ivan Kalvachev]

I'm not X expert, but this commit looks fishy to me.
Are you sure that you haven't broke the xinerama support.

It is very easy to break many WM by making fox for only one. Have you
tested with more WM that fvwm?
Please, We have an very active X code maintainer, consult with him
before making commit.
Especially in so sensible code as X fullscreen one.

More...
about libmpeg2 update that you have commited some time ago. Are you aware
that it cannod decode B-frames atm, givin alful image of mplayer atm.
If you don't fix it in few hours, the whole code will be reverted.

Wish You Best
   Ivan Kalvachev
  iive




Jindrich Makovicka CVS said:
> CVS change done by Jindrich Makovicka CVS
>
> Update of /cvsroot/mplayer/main/libvo
> In directory mail:/var2/tmp/cvs-serv569
>
> Modified Files:
> 	x11_common.c
> Log Message:
> don't mess with the window after setting EWMH_FULLSCREEN (needed for fvwm)
>
> Index: x11_common.c
> =================================================================== RCS
file: /cvsroot/mplayer/main/libvo/x11_common.c,v
> retrieving revision 1.176
> retrieving revision 1.177
> diff -u -r1.176 -r1.177
> --- x11_common.c	8 Aug 2004 23:22:04 -0000	1.176
> +++ x11_common.c	23 Aug 2004 09:36:49 -0000	1.177
> @@ -1466,13 +1466,13 @@
>              vo_x11_setlayer(mDisplay, vo_window, vo_ontop);
>
>          XMoveResizeWindow(mDisplay, vo_window, x, y, w, h);
> -    }
>  #ifdef HAVE_XINERAMA
> -    vo_x11_xinerama_move(mDisplay, vo_window);
> +	vo_x11_xinerama_move(mDisplay, vo_window);
>  #endif
>
> -    XMapRaised(mDisplay, vo_window);
> -    XRaiseWindow(mDisplay, vo_window);
> +	XMapRaised(mDisplay, vo_window);
> +	XRaiseWindow(mDisplay, vo_window);
> +    }
>      XFlush(mDisplay);
>  }
>
>
> _______________________________________________
> Mplayer-cvslog mailing list
> Mplayer-cvslog at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-cvslog
>