[Mplayer-cvslog] CVS: main/DOCS/tech slave.txt,1.12,1.13

The Wanderer inverseparadox at comcast.net
Sun Aug 22 21:26:35 CEST 2004


Joey Parrish CVS wrote:

> +sub_select
> +    Cycle through the subtitle set.  Supported subtitle sources are -sub
> +    options on the command line, VOBSubs, DVD subtitles, and OGG text
> +    streams.

Miscapitalization of "Ogg" and "VOBsub"; also, how are VOBsubs distinct
from "DVD subtitles"?

While I'm at it: "available subtitles" might be a little more clear than
"subtitle set". It took me a moment to figure out unambiguously what was
meant.

 From a slightly later commit:

> +vo_rootwin
> +	Toggle playback on the root window. This runtime toggle is only
> +	supported by the directx driver at the moment.

I'd suggest "is currently supported only by the DirectX driver", or
"currently works only with -vo directx" if the capitalization is because
this is an explicit reference to that video-out method.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.




More information about the MPlayer-cvslog mailing list