[Mplayer-cvslog] CVS: main ChangeLog,1.101,1.102

[The Wanderer]

Coming back at this - now in even heavier nitpick mode, but covering
only the stretch in which I skipped mentioning things before; be warned
that I tend towards perfectionism. <grin>

There are many more than the four comments I mentioned before (and I'm
not even sure I caught all of the four I'd previously seen); part of
that is that I'm not limiting myself to pointing out possible mistakes
in the corrections made, but also possible mistakes in things which
weren't changed. I'm not sure why, but I'm just noticing these more this
time through... maybe it's because I'm more awake.

Diego Biurrun CVS wrote:

> CVS change done by Diego Biurrun CVS
> 
> Update of /cvsroot/mplayer/main
> In directory mail:/var2/tmp/cvs-serv15715
> 
> Modified Files:
> 	ChangeLog 
> Log Message:
> The eve of a new release is always a good time to take history lessons, so
> I read the changelog in an editor...

> RCS file: /cvsroot/mplayer/main/ChangeLog,v
> retrieving revision 1.101
> retrieving revision 1.102
> diff -u -r1.101 -r1.102
> --- ChangeLog	26 Apr 2004 14:41:43 -0000	1.101
> +++ ChangeLog	26 Apr 2004 19:41:22 -0000	1.102

> @@ -608,21 +608,22 @@
>      * new noise removal filter: -vop denoise3d
>      * per-channel gamma and MMX-opt'ed bri/cont/saturation support in -vop eq2
>      * live.com lib support cleanup, support for more stream types
> -    * importing the playtree into the Gui instead of gui's own playlist hack
> -    * support for the XviD and DivX4/5linux libraries at the same time
> +    * playtree imported into the GUI instead of the GUI's own playlist hack
> +    * support for the XviD and DivX4/5Linux libraries at the same time
>      * -fstype option: override priority/layer of the fullscreen switch methods

I don't think the L in "DivX4linux" is supposed to be capitalized.

>      * the usual compiler warning fixes :)
>      * use -pphelp instead of -vop pp=help
>      * various bigendian fixes
> -    * 16bpp packed yuv fixes in crop, mirror, rotate filters
> -    * some -fixed-vo and vo_preinit fixes, -vo sdl,xmga,mga should work...
> +    * 16bpp packed YUV fixes in crop, mirror, rotate filters
> +    * some -fixed-vo and vo_preinit fixes, -vo sdl, xmga, mga should work...
>      * various Solaris compatibility fixes (should work out of the box)
>      * mms:// port fixes, tries 1755 if 80 failed
>      * libavcodec: various ME fixes, B frames fixes, WMV2 slice decoding fixes

I think it's possible that the spaces between the VO methods were
omitted intentionally - that is the format used in the config file. This
one appears in at least one other location, as well, which I'll point
out if I notice it.

>      * CDDA seeking fixed
>      * Win32/RealPlayer codecs DLL & 64bit Alpha Linux RealPlayer codecs support
>      * XMMS Input plugins (demuxer & codec) support
> -    * Fixed a bug in MMX optimized mp3lib (triggered by OpenBSD)
> +    * Fixed a bug in MMX optimized mp3lib (triggered by OpenBSD).

"MMX-optimized" is being used as an adjective, and so needs a hyphen.

> -    Gui:
> -    * general code cleanup, more robust gtk code
> -    * preferences: Screensaver, Autosync settings
> +    GUI:
> +    * general code cleanup, more robust GTK code
> +    * preferences: screensaver, Autosync settings
>      * cache=4 fixed (caused jerky/lagging/slow playback with gmplayer)

Just in case: is there a reason why "Autosync" was left capitalized?

>      * -vo png fixed (removed builtin YV12 support, removed OSD)
> -    * some .mp3 playback/seek segfaults fixed
> -    * vidix mach64 colorkey on PPC fixed
> +    * some .MP3 playback/seek segfaults fixed
> +    * VIDIX Mach64 colorkey on PPC fixed
>      * -ao sdl now handles "featureless" soundcards
>      * -vo zr fixes
>      * fixed sig11 if vo init failed

Inconsistent with other fixes - in most places, you converted ".mp3" to
"MP3", but here you left the dot in place.

> -    * various small bugfixes, endianess fixes
> -    * mencoder: -pass option removed, use -divx4opts pass=N / -lavcopts vpass=N
> -    * mencoder: "ff_rate_estimate_qscale: Assertion `q>0.0' failed" fixed!
> -    * mencoder: -ovc xvid fixes, cleanup, enhancements
> +    * various small bug fixes, endianess fixes
> +    * MEncoder: -pass option removed, use -divx4opts pass=N / -lavcopts vpass=N
> +    * MEncoder: "ff_rate_estimate_qscale: Assertion `q>0.0' failed" fixed!
> +    * MEncoder: -ovc xvid fixes, cleanup, enhancements


Sure that isn't "endianness"?

I'm not sure "bugfix" doesn't qualify as a single word.

> @@ -817,8 +821,8 @@
>      * now auto-inserting -vop lavc for MPEG-only vo's
>      * video filter API documented :)
>      * better deblocking filter (-vop pp), pp/npp syntax changed!
> -    * -vop 2xsai - 2x scaler for drawn images (low color cartoon anims)
> -    * -vop unsharp - an sharp/blur filter, nice, but very slow
> +    * -vop 2xsai - 2x scaler for drawn images (low color cartoon animations)
> +    * -vop unsharp - a sharp/blur filter, nice, but very slow
>      * -vop il - (de)interleave fields
>      * -vop swapuv - guess what :)
>      * -vop boxblur - box blur...

"low color" should I think be "low-color".

> -    * various endianess and 64-bit fixes (including mencoder and -ao pcm)
> -    * tons of small compatibility/portability fixes (better cygwin, darwin support)
> +    * various endianess and 64-bit fixes (including MEncoder and -ao pcm)
> +    * many small compatibility/portability fixes (better Cygwin, Darwin support)
>      * GUI fixes (playlist, audio/video equalizer, preferences)

"endianess" vs. "endianness" again.

>      * image distortions when seeking in some MPEG files fixed
>      * libmpdvdkit + gcc 3.x issue solved (our CFLAGS triggered a gcc3 bug...)
>      * GUI aspect ratio and fullscreen switch fixes, cleanups
> -    * low FPS .wmv playback fixed
> +    * low FPS WMV playback fixed
>      * Mac OS X (Darwin) port?
>      * buggy v4l audio grabbing disabled, we cannot fix, but patches are welcomed!

"low FPS" should be "low-FPS" - phrase as adjective again.

>      * DivX audio dll sig11 with glibc 2.1.(2|3) fixed
> -    * includes libmpdvdkit - patched kit of DVD libraries (enabled for linux+freebsd)
> -    * manpages updated
> +    * includes libmpdvdkit - patched kit of DVD libs (enabled for Linux+FreeBSD)
> +    * man pages updated
>      * 'f' (fullscreen switch) fixed for some WMs, still has problems

In other places, you've expanded short forms ("anims" to "animations",
for instance), but here you go the other direction (turning "libraries"
into "libs"). Any reason for this?

>      * greatly enhanced MPEG4 encoder (libavcodec)
>      * audio-only (WAV/MP3/WMA/Ogg) file playback (console only)
>      * playing/encoding audio from separate WAV/MP3 file
> -    * support for more fileformats, including the new and very popular .ogg
> -    * multiple files playback from console, including various playlist formats
> +    * support for more fileformats, including the new and very popular Ogg
> +    * multiple file playback from console, including various playlist formats
>      * and of course, faster than ever... :)

Elsewhere (above, in the pre8 section), you change "fileformat" to "file
format"; here and elsewhere, you leave it alone despite changing other
things on the same line. Which is correct?

> -mplayer (0.60) "The RTFMCounter": Jan 2, 2002
> +MPlayer (0.60) "The RTFMCounter": Jan 2, 2002
>  
>    release:
> -    * minor bugfixes for realmedia/nuppelvideo demuxers
> +    * minor bug fixes for realmedia/nuppelvideo demuxers
>      * docs updates
>      * help file translation updates
>  

Shouldn't that be "RealMedia"?

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.