[Mplayer-cvslog] CVS: main ChangeLog,1.101,1.102

[Diego Biurrun]

The Wanderer writes:
> Diego Biurrun CVS wrote:
> > -    * native SPARC VIS optimizations
> > +    * native Sparc VIS optimizations
> 
> As I understand it, "SPARC" is in fact an acronym, VERA lists it as 
> "Scalable Processor ARChitecture". Unless this line actually refers to 
> something else I'm missing, the all-caps form would be the appropriate one.

Heh, I went to sun.com and saw it written as "Sparc" on their front
page, go figure.  But SPARC is right.

OK, just found out what V.E.R.A (Virtual Entity of Relevant Acronyms)
is, very useful, thanks.  Do you know an online version that has a
good search function?  I found this one:

http://cgi.snafu.de/ohei/user-cgi-bin/veramain-e.cgi

It uses the POST method, which has the disadvantage that I cannot
define a smart bookmark in Fire<creature>/Mozilla (i.e. type "vera
FOO" into the location bar and get a search result for FOO).

> (I thought it stood for "Sun Palo Alto Research Center", but oh well...)

:)

> > -    * finally fixed the compilation on non-mvi capable alpha CPUs
> > +    * finally fixed the compilation on non-mvi capable Alpha CPUs
> 
> Isn't "MVI" an acronym?

Yes, I looked it up, it stands for Motion Video Instructions.

> > -    * a lot of config/cmdline parsing fixes (some of them were at least 100000l bugs)
> > +    * manyconfig/cmdline parsing fixes (some of them were at least 100000l bugs)
> 
> Typo - omitted space after "many".

Oops, thx.

> > -  - VCD-related stuff moved from stream.c to vcd_read.c
> > +  - VCD related stuff moved from stream.c to vcd_read.c
> 
> This is incorrect - the hyphen belongs there.

I agree on second thought.  What is the explicit rule for when to use
hyphens to compose words in English?

> > -  - DivX postprocess filter works for MPEG1 files too! (-divxq 1/3/7/31)
> > +      - DivX postprocess filter works for MPEG1 files, too! (-divxq 1/3/7/31)
> 
> Why the additional indentation?

Slipped through, thanks.

> >    - MPEG layer-2 audio fixed - it's stereo again!!!
> >    - audio select() detection: if detected audio buffer size == 0, then
> > -    exit with message "recompile mplayer with #undef HAVE_AUDIO_SELECT"...
> > +    exit with message "recompile MPlayer with #undef HAVE_AUDIO_SELECT"...
> 
> This change is correct only if that is the exact message output, or if
> the described message no longer occurs.

Agreed.  Just for the fun of looking at a really ooold MPlayer version
I checked the tarball.  The original message is slightly different
from both versions:

printf("Recompile mplayer with #undef HAVE_AUDIO_SELECT in config.h !\n\n");

> As noted, there were about four more arguable and/or less important
> things I noticed but didn't mention; I don't want to get too nitpicky
> and annoying, though it may be too late to worry about that.

It's far too late for that ;)

But don't you worry, if I weren't nitpicky as well I wouldn't be
discussing these things with you, would I? ;)

So feel free to bring on the rest, I'm interested.

While we are at the subject: I'm unsure about the correct of spelling
of "vobsub" vs "VobSub" vs "VOBsub" vs "VOBSub" vs "VOBSUB" and all
five variants are used throughout MPlayer.  There is a VirtualDub
plugin/filter called VobSub, so maybe that is where part of the
confusion originates.  I'm inclined to use "VOBsub".  Since we use VOB
for Video OBject this seems like the most logical spelling for me.

> (Hey, even if I don't understand most of the actual code, maybe I can at
> least contribute by going over things like this....)

Definitely.  There are lots of things that need to be done in this
area.  Off the top of my head:

 * Completely review the docs - they are mostly still written in
   Hunglish and much of it is clumsy and/or hard to understand.  Such
   a review would of course be a good opportunity to extend them.
 * Same thing but for the tech docs.
 * Much of the output MPlayer prints to the console is poor with
   regard to spelling, wording and clarity.  Also we have many printfs
   that ought to be converted to mp_msg calls.  These tasks naturally
   go together.
 * to be continued...

So if you are willing to help this would be most welcome.  I badly
need a hand atm.  Between MPlayer development, documenation, website,
release and legal stuff in its current intensity, work, university and
maybe something else the days are getting really really short..

BTW, this would also legitimize your presence on mplayer-legal ;-)

Diego