[Mplayer-cvslog] CVS: main/libvo x11_common.c,1.165,1.166

[Fabian Franz]

Am Freitag, 2. April 2004 03:28 schrieb Diego Biurrun:
> Gabucino writes:
> > Diego Biurrun wrote:
> > > Would you care to elaborate what exactly was bad about this commit
> > > message and in which way it could be improved?
> >
> > Tell me the common thing in ALSA "syc" + Motif + x11_common .
>
> Tell me the common thing in "criticism" and "constructive".

constructive criticism is good ;-)

Mix of Alsa sync and Motif is bad ... :-)

This time I agree with Gabucino.

The problem is:

Adam did commit changes to two different files with just one message and there 
even was a typo (ok, can happen ...) ...

So one reading Changelog of alsa will think: Huh? What has ALSA to do with 
MOTIF and where are the related changes and vice versa ...

And I must say: For first I really searched for the changes in the file, until 
I realized that this was the Text of a combined commit, which should not be 
allowed through cvs.txt ...

cu

Fabian