[Mplayer-cvslog] CVS: main/liba52 parse.c,1.5,1.6

Sascha Sommer saschasommer at freenet.de
Thu Apr 1 14:45:44 CEST 2004


> Hi,
>
> > > +#if defined(__MINGW32__) && defined(HAVE_SSE)
> > > +    for(i=0;i<10;i++){
> > > +      if((int)samples%16){
> > > +        sample_t* samplestmp=malloc(256 * 12 * sizeof (sample_t));
> > > +        free(samples);
> > > +        samples = samplestmp;
> > > +      }
> > > +      else break;
> > > +    }
>
> uhh, this is fuckin ugly hack

Yeah agree, but I don't think it is worse than the one you once proposed on
irc.
In my test i was never bigger than 1 here.

> > > +    if((int)samples%16){
> > > +      printf("unable to get 16 bit aligned memory => expect crashes
> > when using SSE instructions\n");
> > > +    }
> > > +#endif
>
> and this is unacceptable
> at least disable sse support in this case, insteda of expecting crash
>

Hm sorry, didn't think of this idea.
Fixed.

Sascha




More information about the MPlayer-cvslog mailing list