[Mplayer-cvslog] CVS: main/libvo vo_svga.c,1.68,1.69

[D Richard Felker III]

On Tue, Sep 23, 2003 at 01:43:20AM +0300, Ivan Kalvachev wrote:
> D Richard Felker III said:
> > On Mon, Sep 22, 2003 at 10:15:35AM +0200, Attila Kinali wrote:
> >> On Mon, 22 Sep 2003 02:00:17 +0200
> >> Ivan Kalvachev CVS <iive at mplayerhq.hu> wrote:
> >> > Modified Files:
> >> > 	vo_svga.c
> >> > Log Message:
> >> > blackbar osd support based on patch send by Dimitar Zhekov
> >> <jimmy at is-vn.bg>,
> >> > page code removed/merged, small updates
> >> I thought this patch was rejected because it's useless as -vf expand does
> >> the same job in a vo independent manner ?
> >
> > Agree, reverse such hackish nonsense.
> >
> > Rich
> >
> The last latter in the thread is mine and i warn that i will commit that
> into the svga, nobody say don't so 2 days later i did it.
> Won't revert.

Only Arpi can do cvs reverse, so I was asking him. AFAIK he'll agree
that this code is hideous and should be reversed.

> It is not nosense, the bigges disadvantage of expand it that you should
> point explictly the height to get full screen OSD. this mean that you
> should
> run the file once, and then calculate the height based on aspect and
> width, and
> run it twice to watch it. I don't want to use scale if there is no need to!

Then add an option to expand to auto-select output aspect ratio, i.e.
add sufficient borders so that the output is 4:3 (or whatever the user
selects).

> Anyway, i had it in the todo, and it also fix another bug, when
> image_width < modeinfo->width (oops i forgot to fix that one)
> 
> Many users want subtitles in the black bars, they want it fox xv. they are
> these
> kind of users that donno what video filter is and .... well sdl do it, why
> not the others?

It should be removed from vo_sdl too!!

Rich