[Mplayer-cvslog] CVS: main configure,1.703,1.704

Diego Biurrun diego at biurrun.de
Mon May 12 13:49:55 CEST 2003


Alex Beregszaszi writes:
 > Modified Files:
 > 	configure 
 > Log Message:
 > last cygwin/mingw32 binary codecs support (win32codecs + real) patch by Sascha Sommer
 > 
 > --- configure	11 May 2003 18:47:18 -0000	1.703
 > +++ configure	11 May 2003 18:53:12 -0000	1.704
 > @@ -4145,6 +4144,11 @@
 >  
 >  if test "$_win32" != no ; then
 >      if test -z "$_win32libdir" ; then
 > +      if cygwin || mingw32 ; then
 > +        _win32libdir="codecs"

First of all this should also be done for _xanimlibdir, this patch is
incomplete as it stands now.

Then I believe that Cygwin should behave like any other Unix port and
not expect the codecs in ./codecs/, but in /usr/local/lib/codecs/.

For MinGW I'm not that strongly convinced, but I do not really see the
necessity for the special case.  What's the default usage?  I think
most people use MinGW like Cygwin and start MPlayer from a shell.  For
binary redistribution it should not be a problem to compile with
--with-win32libdir=codecs etc, so I vote to remove this entirely.

I will gladly come up with a patch for this, we just need a consensus
first.

BTW, I think we are missing something like a --with-codecsdir= option
for configure that allows setting all of the different codecs dirs at
once.  If you agree this would be a good idea, I'll send in a patch.

Diego



More information about the MPlayer-cvslog mailing list