[Mplayer-cvslog] CVS: main/libmpcodecs vd_realvid.c,1.20,1.21

[Arpi]

Hi,

> > so the W/4 and H/4 (hmm, maybe real work with 4x4 macroblocks?) is stored
> > in/after the codecdata part. some quick tests shown that it's true for RV20
> > too, and so it fixes the broken RV20 streams in teh WxH dir.
> > why is that if (sh->format==0x30335652) there, then? :)
> yes, good question - I didn't test rv20, and I just didn't want to make it 
> worse than before, so it was a quick hack. :)

it works with rv20 files, at least when extrahdr[1]>=0x20200002

> > and, it seem sthat the above change is far enough to fix these streams, teh
> > vd_realvid.c hack is not needed. am i right, or are there any so-broken
> > streams requireing that part too?
> I don't know, I thought things would break if the images given back by the 
> codec are expected to be bigger than they really are (and with no change they
> did break) - if you say there is a better way, than that's better, I don't 
> know the mpimage stuff well.

i thought that its' enough to set disp_w/disp_h to the values read in that
if(){}, instead of passing them to teh codec and then get them back from the
codec together with the first decoded image.
but it doesn't work that way (work for broken WxH files, but fails for some
normal ones) :(
anyway it works in your way, so it seems the codec has some magic to decide
which WxH values (the first or the second pair) are the correct ones...

since we have 2 sample files, with all codec parameters matching but one
uses teh first, the other uses teh second WxH pair. so i have to assume, the
magic value is inside the coded frame, and not in the codec init parameters.
for now i gave up, it works with your hack, so it's ok for now...

> btw so far with the files with discontinuous video I tested (like Episod 603 - 
> Aspen, 9000bla.rm) work well, so maybe the fix is the correct one finally :)

great!

btw most files work without any extra -mc, only 2 (ro 3?) required -mc 1 for
faster a-v catch up.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino