[Mplayer-cvslog] CVS: main/libvo vo_sdl.c,1.102,1.103

[Felix Buenemann]

On Tuesday 29 July 2003 17:24, Alex Beregszaszi wrote:
> Hi,
>
> > > @@ -896,7 +896,8 @@
> > >
> > >  		||(strcmp(priv->driver, "directx") == 0)
> > >  		||(strcmp(priv->driver, "Quartz") == 0)
> > >  		||((strcmp(priv->driver, "aalib") == 0)
> > >
> > > -		&& priv->X)) {
> > > +		&& priv->X)
> > > +		||(strcmp(priv->driver, "Quartz") == 0)) {
> > >  			if(verbose) printf("SDL: setting windowed mode\n");
> > >              set_video_mode(priv->dstwidth, priv->dstheight,
> > >              priv->bpp,
> > > priv->sdlflags);
> > >  		}
> >
> > Could you explain that this patch is supposed to do.
> > I see only that it adds "Quartz" driver that is already added
> > right before aalib!?
>
> No.. read carefully the code: before aalib it has the priv->X check too,
> ok, I could have removed the first occurance, leaving only the latter
> one, but the original code hasn't got the same behaviour.
>
> No it starts in windowed mode under Quartz if there's no X server
> running, anyway it's a bit confusing, becouse Quartz hasn't got any
> relations to X, or am I false?
IMHO this change is bad, because if you read the code carefully you'll see 
that it checks for x11 || windib || ... || (aalib && priv->X) this is so that 
it'll run aalib output windowed when X is running while noit if we're eg on 
console.
-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________