[Mplayer-cvslog] CVS: main/mp3lib layer2.c,1.2,1.3

Nick Kurshev nickolsk at yandex.ru
Wed Jan 29 10:34:33 CET 2003


Hello, Arpi!

On Tue, 28 Jan 2003 01:25:41 +0100 you wrote:

> Update of /cvsroot/mplayer/main/mp3lib
> In directory mail:/var/tmp.root/cvs-serv7026
> 
> Modified Files:
> 	layer2.c 
> Log Message:
> In mp3lib/sr1.c, look at the line 226:
>   if(fr->sampling_frequency>8) return FALSE;  // valid: 0..8
> which allows fr->sampling_frequency to go up to 8.
> Obviously, the code does not bother about what would happen if
> fr->sampling_frequency lies in the range [3,8].
> patch from Nilmoni Deb, Nick?, Rich
> 
Yes! This is my code! But it really doesn't solve any problems
because the values for matrix were generated randomly from my
mind ;) It was only experimental patch (not for CVS)!
Indeed, the docs documents only first 3 cases: 44.1, 48 and 32kHz
Any other cases are extensions which were somehow documented for
layer III and never for layers I,II. So for now it's perfectly
unclear how to decode low-sample formats (LSF) if the bit
lsf=0 in headers! (In case of lsf=1 this matrix is not used and
everything works fine for any sample rate!)

[snip]
WBR! Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20030129/158f88e9/attachment.pgp>


More information about the MPlayer-cvslog mailing list