[Mplayer-cvslog] CVS: main cfg-mencoder.h,1.62,1.63

[D Richard Felker III]

On Fri, Jan 24, 2003 at 07:54:59AM +0100, Arpi wrote:
> Hi,
> 
> > Log Message:
> > ability to disable the nonsense expand filter is a must! otherwise
> > it's impossible to render subtitles earlier in the filter chain and
> > then scale them down with a scale filter; huge subs will get rendered
> > again on top!! (think dvd/vobsub where you can't just use smaller font
> > size) if anyone has a better way to handle this, do it! (e.g. make it
> > so that the first expand filter disabled osd for the rest of the
> > filter chain)
> 
> hmm.
> vf_expand has:
>     switch(request){
>     case VFCTRL_DRAW_OSD:
>         if(vf->priv->osd) return CONTROL_TRUE;
>     }
> 
> so it stops OSD rendering calls (preventing vo drivers from drawing osd).
> but vf_expand itself doesn't care about this control and always render OSD
> if the 5th parameter is 1. and it's not easy to fix since vf_expand does osd
> rendering in put_image(), earlier than VFCTRL_DRAW_OSD comes.
> 
> maybe we should add another control call as DISABLE_OSD and expand could
> tell the next filters to not render osd even if configured so.
> 
> another way is introducing new osd state: auto, and change mencoder to init
> expand this way.
> so it'll start rendering osd only after first VFCTRL_DRAW_OSD call.

Hmm, perhaps. IMHO it's still nice to have an option to disable the
expand filter altogether, though. Perhaps eventually we'll have
encoders we can slice-render into. :)))

Rich