[Mplayer-cvslog] CVS: main/libmpcodecs vd_ffmpeg.c,1.81,1.82

[D Richard Felker III]

On Sat, Jan 11, 2003 at 10:13:53AM +0100, Zoltan Ponekker wrote:
> 
> Hali
> 
> > +#if LIBAVCODEC_BUILD < 4654
> > +#define PIX_FMT_RGB24 PIX_FMT_BGR24
> > +#define PIX_FMT_RGBA32 PIX_FMT_BGRA32
> > +#endif
> > +
> >  int avcodec_inited=0;
> >
> >  #if defined(FF_POSTPROCESS) && defined(MBR)
> > @@ -350,8 +355,8 @@
> >  	case PIX_FMT_YUV444P: ctx->best_csp=IMGFMT_444P;break; //photo jpeg
> >  	case PIX_FMT_YUV411P: ctx->best_csp=IMGFMT_411P;break; //dv ntsc
> >  	case PIX_FMT_YUV422:  ctx->best_csp=IMGFMT_YUY2;break; //huffyuv perhaps in the future
> > -	case PIX_FMT_BGR24 :  ctx->best_csp=IMGFMT_BGR24;break; //huffyuv
> > -	case PIX_FMT_BGRA32:  ctx->best_csp=IMGFMT_BGR32;break; //huffyuv
> > +	case PIX_FMT_RGB24 :  ctx->best_csp=IMGFMT_BGR24;break; //huffyuv
> > +	case PIX_FMT_RGBA32:  ctx->best_csp=IMGFMT_BGR32;break; //huffyuv
> >  	default:
> >  	    ctx->best_csp=0;
> >  	}
> 
> Imho this is bad, and workaround only :(

Read the change on the ffmpeg list. As far as I can tell, this is the
correct and only logical way to deal with the change. IMHO it's a bad
changed though.

IMHO2 we should remove RGB colorspace stuff, its pointless. :)

Rich