[Mplayer-cvslog] CVS: main/postproc swscale_internal.h,NONE,1.1 swscale.c,1.116,1.117 swscale_template.c,1.97,1.98 swscale.h,1.25,1.26 yuv2rgb.c,1.15,1.16 yuv2rgb_mlib.c,1.4,1.5 yuv2rgb_template.c,1.12,1.13 rgb2rgb.h,1.25,1.26

[Roberto Togni]

On 2003.02.21 21:35 Michael Niedermayer CVS wrote:
> Update of /cvsroot/mplayer/main/postproc
> In directory mail:/var/tmp.root/cvs-serv8199/postproc
> 
> Modified Files:
> 	swscale.c swscale_template.c swscale.h yuv2rgb.c
> 	yuv2rgb_mlib.c yuv2rgb_template.c rgb2rgb.h
> Added Files:
> 	swscale_internal.h
> Log Message:
> yuv2rgb brightness/contrast/saturation/different colorspaces support
> finished
> yuv2rgb deglobalize
> yuv2rgb optimizations / cleanup
> bugs?
> 
> 
[...]
Does not compile

gcc -c -W -Wall -O2 -march=i686 -mcpu=i686 -g3  -D_REENTRANT 
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  -I. -I..  -I.. -o yuv2rgb.o 
yuv2rgb.c
In file included from yuv2rgb.c:40:
rgb2rgb.h: In function `yuv2rgb':
rgb2rgb.h:87: warning: unused parameter `image'
rgb2rgb.h:87: warning: unused parameter `py'
rgb2rgb.h:88: warning: unused parameter `pu'
rgb2rgb.h:88: warning: unused parameter `pv'
rgb2rgb.h:89: warning: unused parameter `h_size'
rgb2rgb.h:89: warning: unused parameter `v_size'
rgb2rgb.h:90: warning: unused parameter `rgb_stride'
rgb2rgb.h:90: warning: unused parameter `y_stride'
rgb2rgb.h:90: warning: unused parameter `uv_stride'
rgb2rgb.h: In function `yuv2rgb_init':
rgb2rgb.h:94: warning: unused parameter `bpp'
rgb2rgb.h:94: warning: unused parameter `mode'
yuv2rgb.c: In function `yuv2rgb_c_1_ordered_dither':
yuv2rgb.c:557: parse error before `const'
yuv2rgb.c:572: `out_1' undeclared (first use in this function)
yuv2rgb.c:572: (Each undeclared identifier is reported only once
yuv2rgb.c:572: for each function it appears in.)
yuv2rgb.c:572: `d128' undeclared (first use in this function)
yuv2rgb.c:573: `out_2' undeclared (first use in this function)
yuv2rgb.c:555: warning: unused variable `V'
yuv2rgb.c:555: warning: unused variable `U'
yuv2rgb.c:555: warning: unused variable `b'
yuv2rgb.c:555: warning: unused variable `r'
yuv2rgb.c: At top level:
rgb2rgb.h:90: warning: `yuv2rgb' defined but not used
rgb2rgb.h:94: warning: `yuv2rgb_init' defined but not used
yuv2rgb.c:376: warning: `yuv2rgb_c_8' defined but not used
yuv2rgb.c:431: warning: `yuv2rgb_c_4' defined but not used
yuv2rgb.c:503: warning: `yuv2rgb_c_4b' defined but not used
make: *** [yuv2rgb.o] Error 1

attached patch solves the problem.

Ciao,
  Roberto
-------------- next part --------------
--- yuv2rgb.c	Fri Feb 21 22:01:41 2003
+++ yuv2rgb.c.r	Fri Feb 21 22:38:26 2003
@@ -553,9 +553,9 @@
 EPILOG(8)
 
 PROLOG(yuv2rgb_c_1_ordered_dither, uint8_t)
-	g= c->table_gU[128] + c->table_gV[128];
 	const uint8_t *d128=dither_8x8_220[y&7];
 	char out_1=0, out_2=0;
+	g= c->table_gU[128] + c->table_gV[128];
 
 #define DST1bpp1(i,o)					\
 	Y = py_1[2*i];				\