[Mplayer-cvslog] CVS: main m_config.h,1.3,1.4 cfgparser.h,1.19,1.20 [BUG+PATCH]

[Pierre Lombard]

Hi,

* Arpi of Ize <arpi at mplayerhq.hu> [2003-08-12 20:07]:
> Update of /cvsroot/mplayer/main
> In directory mail:/var/tmp.root/cvs-serv16894
> 
> Modified Files:
> 	m_config.h cfgparser.h 
> Log Message:
> min/max float->double

Missing chunk in m_option.h (patch attached).

(Error seen
Reading config file /home/pl/.mplayer/config
Warning unknown option vo at line 14
Warning unknown option ao at line 17
Warning unknown option fs at line 20
...
)

I'd apply it but not too sure about that code and the comment above the
code in m_options.h lets me think it may not be a proper fix (removing
the legacy code may be cleaner ?)

Fyi, the comment is:
/// This is the same thing as a struct config it have been renamed
/// to remove this config_t, m_config_t mess. Sorry about that,
/// config_t is still provided for backward compat.


> Index: m_config.h
> ===================================================================
> RCS file: /cvsroot/mplayer/main/m_config.h,v
> retrieving revision 1.3
> retrieving revision 1.4
> diff -u -r1.3 -r1.4
> --- m_config.h	12 Apr 2003 13:40:30 -0000	1.3
> +++ m_config.h	12 Aug 2003 18:00:08 -0000	1.4
> @@ -71,7 +71,7 @@
>    void *p; 
>    struct m_option_type* type;
>    unsigned int flags;
> -  float min,max;
> +  double min,max;
>    void* priv;
>  };
>  
> 
> Index: cfgparser.h
> ===================================================================
> RCS file: /cvsroot/mplayer/main/cfgparser.h,v
> retrieving revision 1.19
> retrieving revision 1.20
> diff -u -r1.19 -r1.20
> --- cfgparser.h	4 Jul 2003 21:35:43 -0000	1.19
> +++ cfgparser.h	12 Aug 2003 18:00:08 -0000	1.20
> @@ -57,7 +57,7 @@
>  	void *p;
>  	unsigned int type;
>  	unsigned int flags;
> -	float min,max;
> +	double min,max;
>    /* Use this field when your need to do something before a new value is
>       assigned to your option */
>  	cfg_default_func_t default_func;

-- 
Best regards,
  Pierre Lombard
-------------- next part --------------
Index: m_option.h
===================================================================
RCS file: /cvsroot/mplayer/main/m_option.h,v
retrieving revision 1.6
diff -u -r1.6 m_option.h
--- m_option.h	2 Apr 2003 16:15:06 -0000	1.6
+++ m_option.h	13 Aug 2003 09:02:17 -0000
@@ -134,7 +134,7 @@
   void *p; 
   m_option_type_t* type;
   unsigned int flags;
-  float min,max;
+  double min,max;
   // This used to be function pointer to hold a 'reverse to defaults' func.
   // Nom it can be used to pass any type of extra args.
   // Passing a 'default func' is still valid for all func based option types