[Mplayer-cvslog] CVS: main cfg-mencoder.h,1.66,1.67

[Diego Biurrun]

Diego Biurrun writes:
 > Arpi writes:
 >  > > > Please pardon my ignorance if this is obviously wrong, but why didn't
 >  > > > you add this to cfg-common.h instead?
 >  > > 
 >  > > It really should be there, but config-common.h is rather strange. It
 >  > > doesn't declare any of the external variables it needs; it assumes
 >  > > they're already available. And I wasn't sure if it was ok to add
 >  > > extern stuff to cfg-common.h. If it's really no problem, feel free to
 >  > > move them.
 >  > 
 >  > lol :)
 >  > 
 >  > it's even more tricky (ok, call it ugly): the lower half of cfg-common.h
 >  > contains the extern lines. it's included twice, with a #define changed,
 >  > first the lower half (externs) are processed, next tiem the upper half
 >  > (middle part of teh config)t struct).
 > 
 > OK, that helped.  How about this patch:

[...]

No reaction is interpreted as no objection, so I'll commit this
tomorrow.

Diego