[Mplayer-cvslog] CVS: 0_90 configure,1.670,1.671

Diego Biurrun diego at biurrun.de
Tue Aug 5 01:03:33 CEST 2003


Diego Biurrun writes:
 > Arpi writes:
 >  > > Arpi writes:
 >  > >  > > -	for I in "$_libdir/codecs" "$_libdir/real" /usr/lib/real \
 >  > >  > > +	for I in "$_libdir/codecs" "$_libdir/real" "$_libdir/win32" /usr/lib/real \
 >  > >  > >  	  /usr/lib/RealPlayer*/Codecs /usr/local/RealPlayer*/Codecs \
 >  > >  > >  	  /usr/local/lib/RealPlayer*/Codecs /opt/RealPlayer*/Codecs; do
 >  > >  > 
 >  > >  > imho this is broken!!!!!
 >  > >  > 
 >  > >  > it will stop searching for realplayer installations if it find $_libdir/win32
 >  > >  > 
 >  > >  > and anyway, shouldn't it be $win32libdir instead of $libdir/win32 ?
 >  > > 
 >  > > Yes.  So what about
 >  > > 
 >  > >   for I in "$_libdir/codecs" "$_libdir/real" /usr/lib/real \
 >  > >     /usr/lib/RealPlayer*/Codecs /usr/local/RealPlayer*/Codecs \
 >  > >     /usr/local/lib/RealPlayer*/Codecs /opt/RealPlayer*/Codecs \
 >  > >     "_win32libdir"; do
 >  > 
 >  > maybe "$_win32libdir" :)
 > 
 > Oh dear, that was far too early in the morning... and there is already
 > so much Cola involved that a bit more does not matter much ;)
 > 
 > OK to commit with the missing $ added?

Committing in t-24h if nobody objects.

Diego



More information about the MPlayer-cvslog mailing list