[Mplayer-cvslog] CVS: main/libmpdemux demux_realaud.c,NONE,1.1

[Roberto Togni]

On 2003.04.30 22:01 Arpi wrote:
> Hi,
> 
> > int ra_check_file(demuxer_t* demuxer)
> > {
> > 	unsigned int chunk_id;
> >
> >   stream_reset(demuxer->stream);
> >   stream_seek(demuxer->stream, 0);
> 
> this stream_reset/stream_seek is unneede dhere, and it's even wrong,
Ok, i'll remove it. I copied it from another demuxer.

> it
> should be stream_seek(demuxer->stream, demuxer->stream->start_pos),
> but
> it's already done by demuxer.c before calling ra_check_file()...
> 
> > 	if (sh->format == 0x2000) {
> > 		// if DNET, swap bytes, as DNET is byte-swapped AC3:
> > 		char *ptr = dp->buffer;
> > 		int i;
> > 		for (i = 0; i < len; i += 2) {
> > 			const char tmp = ptr[0];
> > 			ptr[0] = ptr[1];
> > 			ptr[1] = tmp;
> > 			ptr += 2;
> > 		}
> > 	}
> 
> i'm thinking about if we move this byte-swapping to the codecs it
> would be
> cleaner, esp. that ad_hwac3. does such byteswapping again.
Ok for me.

> 
> > 	dp->pts = demuxer->filepos / ra_priv->data_size;;
> 
> is that double ;; by reason?
No, just a typo.

> 
> 
> A'rpi / Astral & ESP-team
> 
Ciao,
  Roberto