[Mplayer-cvslog] CVS: main/libmpcodecs vf_tfields.c,1.2,1.3

[D Richard Felker III]

On Wed, Apr 30, 2003 at 08:22:10PM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Wednesday 30 April 2003 19:55, D Richard Felker III wrote:
> > On Tue, Apr 29, 2003 at 11:56:33AM +0200, Michael Niedermayer wrote:
> > > Hi
> > >
> > > On Monday 28 April 2003 04:54, Richard Felker CVS wrote:
> > > > Update of /cvsroot/mplayer/main/libmpcodecs
> > > > In directory mail:/var/tmp.root/cvs-serv5280/libmpcodecs
> > > >
> > > > Modified Files:
> > > > 	vf_tfields.c
> > > > Log Message:
> > > > new mode for tfields filter -- shifts fields by a quarter-pixel so the
> > > > output picture doesn't bob up and down :)
> > >
> > > hmm linear interpolation sucks IMHO, why dont u use some filter like
> > > (-9a + 111b + 29c -3d + 64)>>7 or (-a + 14b + 3c + 8)>>4
> >
> > Because I'm lazy and don't know how to make this perform decent in
> > mmx...
> i cant imagine any tricks beyond a simple unpack, multiply, add, ..., shift, 
> pack mmx implementation either ATM, but i guess its still more then fast 
> enough 

Hmm, ok, I've never done mmx multiply. Do you unpack first, or does
the multiply automatically give 16bit outputs for 8bit inputs?

> > Also, I'm a bit skeptical of wider filters with with sharp edges
> > (common in anime)... What do you think about this?
> yes, wide filters will create ugly wave effects around edges (just try -sws 8)
> but 3tap/4tap isnt wide, and short filters suck too for edges as they blur 
> them

OK, I'll see if I can improve it. :) I'm already rather happy with the
results, so if it looks better with a nicer filter, that'll be great!

Rich