[Mplayer-cvslog] CVS: main/libmpdemux demux_mov.c,1.83,1.84

Dominik Mierzejewski dominik at rangers.eu.org
Sat Nov 23 19:18:19 CET 2002


On Saturday, 23 November 2002, Gábor Lénárt wrote:
> On Sat, Nov 23, 2002 at 06:32:08PM +0100, Michael Niedermayer CVS wrote:
> > @@ -527,7 +527,7 @@
> >  		break;
> >  	    }
> >  	    case MOV_FOURCC('s','t','t','s'): {
> > -		stream_read_dword(demuxer->stream);
> > +		int temp=stream_read_dword(demuxer->stream);
> >  		int len=stream_read_dword(demuxer->stream);
> 
> Hmmm, I've fixed the bug with moving stream_read_dword()'s after variable
> declarations. Imho everyone who can code C *SHOULD* know that you can't do this:
> 
> {
> 	some_function();
> 	int variable;
> ....
> 
> It's a very stupid bug. Please note, that it's NOT C++, it's C!

Yes, yes. Won't happen again, I promise.

-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"



More information about the MPlayer-cvslog mailing list