[Mplayer-cvslog] CVS: main/libmpdemux audio_in.c,1.6,1.7 demux_asf.c,1.25,1.26 demux_avi.c,1.51,1.52 demux_mov.c,1.82,1.83 demux_mpg.c,1.45,1.46 demux_pva.c,1.3,1.4 demux_real.c,1.33,1.34 demux_viv.c,1.23,1.24 tv.c,1.39,1.40 tvi_v4l.c,1.40,1.41

[Alex Beregszaszi]

On Sat, 23 Nov 2002 18:05:14 +0100 Michael Niedermayer <michaelni at gmx.at> wrote:

> Hi
> 
> On Saturday 23 November 2002 17:21, Alex Beregszaszi wrote:
> > Hi,
> >
> > > Index: demux_mov.c
> > > ===================================================================
> > > RCS file: /cvsroot/mplayer/main/libmpdemux/demux_mov.c,v
> > > retrieving revision 1.82
> > > retrieving revision 1.83
> > > diff -u -r1.82 -r1.83
> > > --- demux_mov.c	11 Nov 2002 23:46:27 -0000	1.82
> > > +++ demux_mov.c	23 Nov 2002 10:58:08 -0000	1.83
> > > @@ -527,7 +527,7 @@
> > >  		break;
> > >  	    }
> > >  	    case MOV_FOURCC('s','t','t','s'): {
> > > -		int temp=stream_read_dword(demuxer->stream);
> > > +		stream_read_dword(demuxer->stream);
> >
> > 1000L !
> > reverse this file !
> ok, but could u explain why it is bad? i cant see where temp is used ...
it's not used but at least my gcc 2.95.4 didn't support declaring variables after
some func calls. so:
{
stream_read_dword(demuxer->stream);
int len = stream_read_dword(demuxer->stream);
}
is bad.

that temp isn't used, but the right fix would be that just declare int len
and later after the first dword skip set it to the right value.
{
int len;
stream_skip_dword(demuxer->stream);
len = stream_read_dword(demuxer->stream);
}

-- 
Alex Beregszaszi  <alex at naxine.org>
(MPlayer Core Developer -- http://www.mplayerhq.hu/)