[Mplayer-cvslog] CVS: main/libmpcodecs ad_a52.c,NONE,1.1

Arpi arpi at thot.banki.hu
Mon Mar 25 22:47:59 CET 2002


Hi,

> > 	ad_a52.c ad_acm.c ad_alaw.c ad_dk3adpcm.c ad_dk4adpcm.c 
> > 	ad_dshow.c ad_dvdpcm.c ad_ffmpeg.c ad_hwac3.c ad_imaadpcm.c 
> > 	ad_internal.h ad_mp3.c ad_msadpcm.c ad_pcm.c ad_roqaudio.c 
> > Log Message:
> > imported from MPlayerXP, dlopen() hack removed, some bugs fixed, interface
>  functions changed to static, info->author field added
> 
> 	Well how about that? I'm glad to see that we're already beginning
> to roll some of the MPlayerXP code back into the main MPlayer
> codebase...:)

hehe
btw while you're watching it, you should actually get your cyber-pen and
fix your codecs... they are very broken, at least the videpoint of design.
you use such hacks:

  static unsigned char *ibuf = NULL;
  if (!ibuf)
    ibuf = (unsigned char *)malloc(sh_audio->wf->nBlockAlign);

instead of:
- using sh_audio->a_in_buffer as pointer
- doing allocation at init() stage

please fix these ASAP...


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-cvslog mailing list